-
-
Notifications
You must be signed in to change notification settings - Fork 611
feat(ui): customizable dashboard heading and subheading #1235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Was about to start work on this but then I saw the PR - would be keen for this to get through! :) Appears to also be requested in #1299 |
|
Out of curiosity, what did you want to modify them to? Did you want to completely remove them (i.e. set them to |
|
I’d like to make the wording clearer for my users, especially the endpoint part. It’s mostly a personal preference, so I thought making it customizable would be best. |
|
Would really love the option to modify them, or even hide that whole div to be honest, but would settle for being able to set them blank or to something custom. For now I've just dropped it entirely with |
config/ui/ui.go
Outdated
| defaultTitle = "Health Dashboard | Gatus" | ||
| defaultDescription = "Gatus is an advanced automated status page that lets you monitor your applications and configure alerts to notify you if there's an issue" | ||
| defaultHeader = "Gatus" | ||
| defaultDashboardTitle = "Health Dashboard" | ||
| defaultDashboardDescription = "Monitor the health of your endpoints in real-time" | ||
| defaultLogo = "" | ||
| defaultLink = "" | ||
| defaultCustomCSS = "" | ||
| defaultSortBy = "name" | ||
| defaultFilterBy = "none" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please align using spaces, not tabs.
config/ui/ui.go
Outdated
| Title string `yaml:"title,omitempty"` // Title of the page | ||
| Description string `yaml:"description,omitempty"` // Meta description of the page | ||
| DashboardTitle string `yaml:"dashboard-title,omitempty"` // Dashboard Title between header and endpoints | ||
| DashboardDescription string `yaml:"dashboard-description,omitempty"` // Dashboard Description between header and endpoints | ||
| Header string `yaml:"header,omitempty"` // Header is the text at the top of the page | ||
| Logo string `yaml:"logo,omitempty"` // Logo to display on the page | ||
| Link string `yaml:"link,omitempty"` // Link to open when clicking on the logo | ||
| Buttons []Button `yaml:"buttons,omitempty"` // Buttons to display below the header | ||
| CustomCSS string `yaml:"custom-css,omitempty"` // Custom CSS to include in the page | ||
| DarkMode *bool `yaml:"dark-mode,omitempty"` // DarkMode is a flag to enable dark mode by default | ||
| DefaultSortBy string `yaml:"default-sort-by,omitempty"` // DefaultSortBy is the default sort option ('name', 'group', 'health') | ||
| DefaultFilterBy string `yaml:"default-filter-by,omitempty"` // DefaultFilterBy is the default filter option ('none', 'failing', 'unstable') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same alignment comment here
config/ui/ui.go
Outdated
| DashboardTitle string `yaml:"dashboard-title,omitempty"` // Dashboard Title between header and endpoints | ||
| DashboardDescription string `yaml:"dashboard-description,omitempty"` // Dashboard Description between header and endpoints |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be named DashboardHeading and DashboardSubheading.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the config should also reflect this naming?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe even creating an object called dashboard?
dashboard:
heading: asdf
subheading: hjklThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to create a parent dashboard object for now, just dashboard-heading and dashboard-subheading is fine
config/ui/ui_test.go
Outdated
| DashboardTitle: "", | ||
| DashboardDescription: "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be aligned
|
@RezeOW could you be so kind and fix the alignment issues soon? |
|
I am very sorry, |
|
@RezeOW Would you mind fixing the conflict when you have a minute? |
|
I am gonna be honest, I am not a js dev and I dont want to break your app :( |
|
@RezeOW don't worry about it. I'll fix it when I have some time to work on this (unless somebody beats me to it). I appreciate the effort nevertheless :) |
c12179d to
9f76d25
Compare
|
@TwiN I've rebased and rebuiled the frontend, should be ready for merge. Would appreciate a quick release, so I can deploy this to production. @RezeOW thanks for responding fast. I've simply rebased your branch and run |
|
@macmoritz I appreciate your help, thanks! |
|
Excellent work folks. |
|
OMG, I was really looking forward to this feature! Thanks everyone! 🎉 👏 |
Summary
I wanted to edit the dashboard texts, but they were hard coded, so I made them editable via the config.yaml file
Checklist
README.md, if applicable.